Make GTUtil.canSeeSunClearly work for all dimensions even if they have fixed time enabled - #5239
Merged
gustovafing merged 3 commits intoAug 6, 2026
Conversation
gustovafing
approved these changes
Aug 4, 2026
Member
|
can we remove javd from the gradle as well? |
Member
|
I don't think javd is a gradle dep |
gustovafing
added
type: bugfix
gustovafing
enabled auto-merge (squash)
August 6, 2026 08:33
gustovafing
added a commit
that referenced
this pull request
Aug 6, 2026
…e fixed time enabled (#5239) Co-authored-by: Gustavo <77560533+gustovafing@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the special case for JAVD in
GTUtil.canSeeSunClearly()in favor of a fully generic solutionImplementation Details
copied
Level#isDay's logic and removed the check that made fixed time be neither day or night.Also removed the duplicate
Level.getBiome(pos.above())call by storing the biome's holder in a variable instead of the biome itselfAI Usage
Outcome
void dimension mods other than JAVD will also work now
How Was This Tested
ran game, went into Just Another Void Dimension, placed solar boiler, filled with water, waited.